search

SamB440 / Tale-of-Kingdoms

An adventure of glory in the world of Minecraft - Revival of Tale of Kingdoms mod
GNU General Public License v3.0
16 stars 2 forks source link

Master - [merged] #83

Closed SamB440 closed 2 years ago

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 1, 2020, 18:20

Merges master -> master

Closes issues #29 #20 and #14

SamB440 commented 3 years ago

Kill it instead. Don't force remove it, then you won't need to catch the exception.

SamB440 commented 3 years ago

Enforce this as HunterEntity type.

SamB440 commented 3 years ago

It should not be accessible in this way. The add and remove methods allow us to conntrol it. Is this really needed?

SamB440 commented 3 years ago

For the same reasons in regards to access, an ImmutableList#of(hunterUUIDs) should be used here. This will mean you can only read the values.

SamB440 commented 3 years ago

Should be translatable

SamB440 commented 3 years ago

Should be translatable

SamB440 commented 3 years ago

Should be translatable

SamB440 commented 3 years ago

Not needed?

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 112

changed this line in version 2 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/common/world/ClientConquestInstance.java line 82

changed this line in version 2 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 115

changed this line in version 2 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 111

changed this line in version 2 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 108

changed this line in version 2 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

Commented on src/main/java/com/convallyria/taleofkingdoms/client/gui/entity/GuildMasterScreen.java line 92

changed this line in version 2 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:31

added 1 commit

Compare with previous version

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:57

Commented on src/main/java/com/convallyria/taleofkingdoms/common/world/ClientConquestInstance.java line 68

changed this line in version 3 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 14:57

added 1 commit

Compare with previous version

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 16:25

added 1 commit

Compare with previous version

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 16:55

Commented on src/main/java/com/convallyria/taleofkingdoms/common/world/ClientConquestInstance.java line 73

changed this line in version 5 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Dec 24, 2020, 16:55

added 1 commit

Compare with previous version

SamB440 commented 3 years ago

resolved all threads

SamB440 commented 3 years ago

approved this merge request

SamB440 commented 3 years ago

requested review from @SamB440

SamB440 commented 3 years ago

mentioned in commit e84d566a9fbd2103d745a11b438b42dd1813fa90