search

SamB440 / Tale-of-Kingdoms

An adventure of glory in the world of Minecraft - Revival of Tale of Kingdoms mod
GNU General Public License v3.0
17 stars 3 forks source link

Guild attack implementation - [merged] #97

Closed SamB440 closed 2 years ago

SamB440 commented 3 years ago

Merges guild-attack -> master

This implements the guild attack and fixes lots of other bugs.

Signed-off-by: SamB440 sam@islandearth.net

SamB440 commented 3 years ago

DeepCode's analysis on #44f44c found:

Description Example fixes
Consider checking the presence of the optionals value with isPresent before accessing it with get Occurrences: :wrench: Example fixes
Use getBlockState instead of getBlock. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

SamB440 commented 3 years ago

Not sure about all the additions here, but oh well!

SamB440 commented 3 years ago

resolved all threads

SamB440 commented 3 years ago

mentioned in commit 63d5855194a4d1f73bccccfe0d11c341e86b36f3