search

SamCoVT / TaliForth2

A Subroutine Threaded Code (STC) ANSI-like Forth for the 65c02
Other
28 stars 4 forks source link

update references to native_words.asm #103

Closed patricksurry closed 1 month ago

patricksurry commented 2 months ago

Fixes #95

Assuming you are OK with the headers.asm changes I'll need to update "Adding the Header in headers.asm" in ch_developing.adoc. I can do that in this PR if you like.

SamCoVT commented 2 months ago

Which changes to the headers were you talking about here? There is the macro-izing of the headers, which I don't think I like very much (it makes them more succinct, but doesn't show the structure of the header in the source anymore), and the possibly reduced size, which I don't think is fully fleshed out yet.

The PR you've linked to here looks fine so far. If you're just going to be updating where the headers are, I think that's fine to do in this same PR.

patricksurry commented 2 months ago

Yup, I was planning to move headers.asm from top-level into words/. That change is already in #98 but I can make a similar change here if you want.

I admit I like the macro approach since it avoids a whole class of easy mistakes where you miscount a word length or accidentally put the wrong 'next' label etc, and we can still have a lengthy description of the actual structure in the comments. It also made it easier to notice a few cases where, e.g. UF or HC bits weren't right. But most importantly it makes it much easier to experiment with different header formats without having to make coordinated changes in 200+ places 😅 (I guess that will be especially true if the header declarations get scattered near the word definitions per other discussion.)

patricksurry commented 1 month ago

this should be good to go - it doesn't discuss any restructuring/macro-izing of headers, just moves it as is into the words folder. if/when we decide to make header structure changes i'll update the relevant docs then.

SamCoVT commented 1 month ago

I think this already got merged with one of the other PRs - I already have headers.asm in the words folder in my master-64tass branch, and I checked the Makefile and see the changes you made there appear to already exist in the master-64tass branch. You can double-check in case I'm missing anything, but GitHub is showing no file changes relative to master now.

patricksurry commented 1 month ago

yup, i must have messed up updating one of the branches after the w_ label change. this one's empty so I'll close it