search

SamColl / colmaracademy

codeacademy project
0 stars 0 forks source link

Summary #3

Open mp1pro opened 6 years ago

mp1pro commented 6 years ago

The structure of the html and css is correct. Most of the design passed successfully. You are also missing the footer section. Some background colors are also missing. Each section should alternate between white and grey backgrounds similar to the mock-up. Great overall effort.

SamColl commented 6 years ago

Hi Martin. Thanks for your review. I think I’ve made an error with my commits as this is not my full project. I was committing to Github via Atom and it would appear none of the commits I made on there have made it to Github! I will send all my commits to master so you can se my completed project. Apologies!

SamColl commented 6 years ago

@mp1pro I've fixed it now. Hope you have the time to take another look. Thanks so much!

mp1pro commented 6 years ago

There is still the issue when linking the stylesheet and images, When you use the path on your PC, the paths will not work when the code is distributed. Instead of 

   <link rel="stylesheet" href="/Users/SamCollins/Documents/GitHub/SamColl.io/colmar/resources/css/reset.css">
    <link rel="stylesheet" href="/Users/SamCollins/Documents/GitHub/SamColl.io/colmar/resources/css/style.css">

use

    <link rel="stylesheet" href="./resources/css/reset.css">
    <link rel="stylesheet" href="./resources/css/style.css">

Test the code like so in another folder. run git clone https://github.com/SamColl/colmaracademy.git click on index.html to see the site.

The other updates were successful.