search

SamDecrock / node-http-ntlm

Node.js module to authenticate using HTTP NTLM
MIT License
192 stars 89 forks source link

Updated ntlm.js, replacing xxxn with BigInt #105

Closed msaadsiddiqui closed 1 year ago

msaadsiddiqui commented 1 year ago

Using BigInt(x) instead if xxxn, though the current one is correct, but it is throwing exceptions in some old versions, for example node soap. like "Invalid or unexpected token". Using BigInt(x) will work with older node versions too.

msaadsiddiqui commented 1 year ago

@SamDecrock hey man, can you please review this PR ?

SamDecrock commented 1 year ago

Thanks @msaadsiddiqui looks good. It seems like the BigInt literal is giving issues with many users. Thanks for the pull request. Merging it.