Issue in ntlm.js file. - Githubissues

SamDecrock / node-http-ntlm

Node.js module to authenticate using HTTP NTLM

MIT License

192 stars 89 forks source link

Closed professionallyMe closed 1 year ago

professionallyMe commented 7 years ago

Hello Sam,

While using the node-http-ntlm module I came around the following issue :

In ntlm.js file at line number 366 , the password_hash is a string so the call fails here saying password_hash.copy() function not defined on strings. Instead , what should be done is password_hash should be passed into a separate buffer and then copy should be called on that.

Thanks for providing a wonderful library.

SamDecrock commented 1 year ago

In my code password_hash is a Buffer, not a string.

Why did you assume password_hash is a string?