search

SamDecrock / node-http-ntlm

Node.js module to authenticate using HTTP NTLM
MIT License
192 stars 89 forks source link

pass along other options #61

Closed NAlexandrov closed 7 years ago

NAlexandrov commented 7 years ago

Add a next code to sendType1Message function, please:

// pass along other options:
type1options.headers = _.extend(type1options.headers, httpreqOptions.headers);
type1options = _.extend(type1options, _.omit(httpreqOptions, 'headers'));

Without this code can not be added rejectUnauthorized in request options

matiasdelgado commented 7 years ago

It used to be exactly as @NAlexandrov suggests, but it was changed in this commit 36e9ad0. Not sure why the options were limited to just timeout and ca, leaving the proxy and other options out. Any thoughts?

SamDecrock commented 7 years ago

Merged this PR. Thanks a lot!