search

SamDecrock / node-http-ntlm

Node.js module to authenticate using HTTP NTLM
MIT License
192 stars 89 forks source link

[Suggestion] Implement doRequest. #65

Closed SPWizard01 closed 1 year ago

SPWizard01 commented 7 years ago

Great library! But, for power users after taking a quick look(not sure how involved this is) something like this worked: https://github.com/SamDecrock/node-http-ntlm/blob/master/httpntlm.js#L107-L109 to ['get', 'put', 'patch', 'post', 'delete', 'options', 'doRequest'].forEach(function(method){ exports[method] = exports.method.bind(exports, method); });

and

https://github.com/SamDecrock/node-http-ntlm/blob/master/httpntlm.js#L93-L94 to if(method !== 'doRequest') { httpreq[method](options.url, type3options, callback); } else { type3options.url = options.url; httpreq[method](type3options, callback); }

SamDecrock commented 1 year ago

Is there more to HTTP than 'get', 'put', 'patch', 'post', 'delete', 'options' ?