SamDel / ChromeCast-Desktop-Audio-Streamer

Stream the sound of your desktop to your Chromecast Audio device
MIT License
412 stars 30 forks source link

Development 2.4 #39

Closed SamDel closed 4 years ago

SamDel commented 5 years ago

Let's discuss 2.2 development here.

elibroftw commented 5 years ago

Add options to startup minimized to icon tray. Add an option or make it so that the app minimizes to the icon tray.

elibroftw commented 5 years ago

Also, could you make the taskbar icon higher in resolution? It looks choppy.

elibroftw commented 5 years ago

Make Desktop Audio Streamer audio independent from windows volume slider. If I decrease the volume for my headset, the volume of the wireless device should not change! Please make the audio streamer volume connected with the volume of the device and not have the current two independent volume sliders. image In this image the headset is 40%, the streamer audio is 100% and the office is ~60%. I understand that the app sends all audio but I just think that the volume should be the raw 100% and then controlled via the casting device controllers. All of this is just my opinion on improving user experience.

elibroftw commented 5 years ago

Also, (this is just a minor detail), you should rename the program from ChromeCast.Desktop.AudioStreamer to Chrome Cast Desktop Audio Streamer or just Audio Stream Caster (anything without punctuation).

elibroftw commented 5 years ago

image This should be more unambiguous: Volume up = Ctrl + Alt + U; Volume down = Ctrl + Alt + D; Muting = Ctrl + Alt + M The muting thing is just personal preference, I just didn't like the (Un) part because there's two capital letters.

elibroftw commented 5 years ago

Another thing, you should attach releases to the release post for each release instead of linking to the release on the repository (waste of space for people who are forking).

SamDel commented 5 years ago

Thanks @elibroftw.

I'll come back on the other issues later.

elibroftw commented 5 years ago

I do have the option unchecked but I had to guess what it did. This is what I would expect. I did figure out that icon part a few minutes after posting the comment. image

As for the icons, it shouldn't be a big priority.

Main 1080p monitor image

Second lower resolution monitor image

SamDel commented 5 years ago

Another thing, you should attach releases to the release post for each release instead of linking to the release on the repository (waste of space for people who are forking).

Good point! I've created a new issue for it.

SamDel commented 5 years ago

Make Desktop Audio Streamer audio independent from windows volume slider. If I decrease the volume for my headset, the volume of the wireless device should not change! Please make the audio streamer volume connected with the volume of the device and not have the current two independent volume sliders.

The volume of the Chromecast device shouldn't change when you change the volume of the headset or speakers. Does it change for you?

The application captures the audio from the soundcard, that's independent from the volume of the headset (but dependent of the volume mixer). I don't think it's a good idea to always link the volume of the desktop to the volume of the device (maybe optional?).

elibroftw commented 5 years ago

I think I was being way too vague. Suppose the volume for my main sound device is 40. When I increase this volume, the volume of the home mini also goes up (the volume setting of the home mini stays the same). I'm not sure if that's the intended way. Other thing is that when viewing the volume mixer, the Chromecast desktop audio streamer app shows 100 and when this is reduced, the volume of the home mini does go down but it's setting stays the same (again not sure if this is intended). I never mentioned this but thanks for your hard work, I appreciate it. Maybe this summer I can help out with the coding too.

SamDel commented 5 years ago

For me, with laptop speakers and the standard 3mm jack, the volume on the device doesn't change when I change the volume of speakers or headphone.

In the screendump I see you're using a Razer Kraken earphone, that's USB isn't it? Maybe it works different then. Do you have the Razer Kraken selected as recording device in the application?

In general I think it works like this (with my standard setup):

You're welcome 😊. Nice you want to help out. I don't have a lot of spare time myself on the moment. Earlier this year we've done a lot of work improving the application.

OneBobone commented 5 years ago

If you try this with the Spotify Web app, you get the same type of problem, i.e. the volume is changed by the slider in the app. Not sure how early you can capture the sound?

SamDel commented 5 years ago

Same here. When I change the volume of the Youtube web player, the web player sends audio at a lower volume to the sound card then. The application captures it at the sound card, and streams it to the devices. You can't capture the Spotify/Youtube/... stream earlier.

elibroftw commented 5 years ago

For the icons thing I said before, could you not just use the icons from acidhax's project?

FA-Bubba commented 5 years ago

I downloaded Streamer version 2.4, and got a warning about an incorrect date...

When I checked the files, they are date-stamped 06/29/2019 5:29 PM, and the current date-time here is 06/29/2019 3:03 PM, so the files do indeed show a future date-time.

elibroftw commented 5 years ago

Could you change the StartPosition of the MainForm to Centre rather than Windows default. Every time I use the app, I have to move it to the centre of the screen. Thanks!

SamDel commented 5 years ago

Setup 2.4.3.zip saves the position of the form (not always in the center). That should work for everyone. Can you try?

elibroftw commented 5 years ago

Awesome it works, thanks!

elibroftw commented 5 years ago

Not sure if you use this but, https://developers.google.com/cast/docs/developers#download_cast_icons

SamDel commented 5 years ago

Thanks, I've generated a Windows icon with one of the images. How's Setup 2.4.4.zip?

SamDel commented 5 years ago

Saving the position didn't work anymore in 2.4.4, that's fixed in Setup 2.4.5.zip. How's the icon for you now @elibroftw ?

elibroftw commented 5 years ago

Yeah sorry about not responding, it looks good.

On Fri, Jul 12, 2019, 12:12 PM SamDel notifications@github.com wrote:

Saving the position didn't work anymore in 2.4.4, that's fixed in Setup 2.4.5.zip https://github.com/SamDel/ChromeCast-Desktop-Audio-Streamer/files/3387190/Setup.2.4.5.zip . How's the icon for you now @elibroftw https://github.com/elibroftw ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SamDel/ChromeCast-Desktop-Audio-Streamer/issues/39?email_source=notifications&email_token=AFCPYI25UTPYYKMMFY6W3JLP7CUQBA5CNFSM4HLJJD22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ2GMFY#issuecomment-510944791, or mute the thread https://github.com/notifications/unsubscribe-auth/AFCPYI6XEKRSL3ZI22PAGRTP7CUQBANCNFSM4HLJJD2Q .

SamDel commented 4 years ago

Here's 2.4.15. I think I will create a 2.5 release of it shortly!

elibroftw commented 4 years ago

Hey, I've made my own app for music casting. But thanks for the inspiration!

SamDel commented 4 years ago

Nice, I will try your app shortly!

SamDel commented 4 years ago

I'm closing this one, let's continue in Development 2.5.

The version 2..5 release is here.