search

SamKirkland / FTP-Deploy-Action

Deploys a GitHub project to a FTP server using GitHub actions
MIT License
3.88k stars 375 forks source link

Similar issue as in #137: "Server sent FIN packet unexpectedly" #197

Open danielrlutz opened 3 years ago

danielrlutz commented 3 years ago

Bug Description Just like in #137 I'm not able to deploy to the FTP server however, I'm confident my hosting provider provides FTP (port 21) and an SFTP(port 5544). When attempting to connect I use the default port number 21 and therefore, as far as I understand connect over the normal FTP protocol. When using Filezilla with the credentials stored in the secrets it works as it should, but not with the action.

My Action Config

on:
  push:
    branches:
      - main
name: 🚀 Deploy to production
jobs:
  web-deploy:
    name: 🎉 Prod Deployment
    runs-on: ubuntu-latest
    steps:
    - name: 🚚 Get latest code
      uses: actions/checkout@v2

    - name: 📂 Sync files
      uses: SamKirkland/FTP-Deploy-Action@4.0.0
      with:
        server: ${{ secrets.ftp_server }}
        username: ${{ secrets.ftp_user_prod }}
        password: ${{ secrets.ftp_password_prod }}

My Action Log

   Run SamKirkland/FTP-Deploy-Action@4.0.0
  with:
    server: ***
    username: ***
    password: ***
    log-level: verbose
----------------------------------------------------------------
🚀 Thanks for using ftp-deploy. Let's deploy some stuff!   
----------------------------------------------------------------
If you found this project helpful, please support it
by giving it a ⭐ on Github --> https://github.com/SamKirkland/FTP-Deploy-Action
or add a badge 🏷️ to your projects readme --> https://github.com/SamKirkland/FTP-Deploy-Action#badge
Creating local state at ./.ftp-deploy-sync-state.json
Local state created
Connected to 116.202.46.46:21 (No encryption)

----------------------------------------------------------------
---------------  🔥🔥🔥 A error occurred  🔥🔥🔥  --------------
----------------------------------------------------------------

----------------------------------------------------------------
----------------------  Full Error below  ----------------------
Error: Server sent FIN packet unexpectedly, closing connection.
    at Socket.<anonymous> (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.0.0/dist/index.js:3602:56)
    at Socket.emit (events.js:215:7)
    at endReadableNT (_stream_readable.js:1184:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
Error: Error: Server sent FIN packet unexpectedly, closing connection.
bryxfr commented 3 years ago

I also have the same problem if I use SFTP. Moreover, 1&1 by Ionos does not offer FTP and FTPS anymore, but only SFTP. GitHub Actions are bad and unusable. I hope the author (@SamKirkland) will succeed in seducing us with new features.

Edit 👍 Otherwise, with version 3.3.1 everything works fine! I can't wait for version 4 to be operational!

on: push name: 🚀 Déployer le site web en push jobs: web-deploy: name: 🎉 Déployer runs-on: ubuntu-latest steps:

danielrlutz commented 3 years ago

fetch-depth : 100

What is 'fetch-depth'?

bryxfr commented 3 years ago

@freakyshine > No idea, I tested with it works.

danielrlutz commented 3 years ago

Fair

Henry31 commented 3 years ago

Thanks a lot @lecomteb27!

I had the same issue. I switched to version 3.1.1, and it works now.

I just figured out that the option --dry-run is not working in version 3.1.1 (especially in combination with the option --insecure). I added dry-run for testing purpose in the first place, when I removed that option, it works for me.

bryxfr commented 3 years ago

With pleasure, @Henry31 :)

Now we must wait for the developer to fix the malfunction in V4. I keep my fingers crossed :)

1manfactory commented 1 year ago

Error: Server sent FIN packet unexpectedly, closing connection.

Tried 3 times. More than 2000 files got uploaded succesfully but then this error occurs.

This is not a hosting problem as I am deplying to my own root server with ProFTPD

hkhieudev commented 1 year ago

@1manfactory Hi, i have same issue.

FTPError: 421 No transfer timeout (300 seconds): closing control connection
    at FTPContext._onControlSocketData (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.3.3/dist/index.js:5254:39)
    at Socket.<anonymous> (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.3.3/dist/index.js:5095:44)
    at Socket.emit (node:events:527:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:285:11)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at TCP.onStreamRead (node:internal/stream_base_commons:190:23) {
  code: 421
}

----------------------------------------------------------------
--------------  🔥🔥🔥 an error occurred  🔥🔥🔥  --------------
----------------------------------------------------------------

----------------------------------------------------------------
----------------------  full error below  ----------------------
----------------------------------------------------------------

Error: Server sent FIN packet unexpectedly, closing connection.
    at Socket.<anonymous> (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.3.3/dist/index.js:5097:56)
    at Socket.emit (node:events:539:35)
    at endReadableNT (node:internal/streams/readable:1345:12)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
Error: Error: Server sent FIN packet unexpectedly, closing connection.

when i deployed ~200files, it worked fine. but when i deployed thousands files, i had same issue. do you have an idea?

simon387 commented 1 year ago

Hello,

same here

Error: Server sent FIN packet unexpectedly, closing connection.
    at Socket.<anonymous> (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/4.1.0/dist/index.js:3788:56)
    at Socket.emit (node:events:539:35)
    at endReadableNT (node:internal/streams/readable:1345:12)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
Error: Error: Server sent FIN packet unexpectedly, closing connection.

gonna try with v4.3.4 and a bigger timeout

AlexKrupko commented 1 year ago

I've faced with the same error. Version 4.3.4 fails with error "Server sent FIN packet unexpectedly". Downgraded it to 3.1.2 and it works as expected.

Sharifur commented 1 year ago

Error: Server sent FIN packet unexpectedly, closing connection. at TLSSocket. (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/v4.3.4/dist/index.js:5098:56) at TLSSocket.emit (node:events:525:35) at endReadableNT (node:internal/streams/readable:1358:12) at processTicksAndRejections (node:internal/process/task_queues:83:21) Error: Error: Server sent FIN packet unexpectedly, closing connection.

facing same error

Sharifur commented 1 year ago

Downgraded to SamKirkland/FTP-Deploy-Action@4.1.0

solved my problem

tabarnouche commented 8 months ago

I was having the same issue and in my case, I had to disable the access filter from overseas in the host configuration screen since it blocks accesses from github.

markoeltiger commented 8 months ago

hello people i fixed this issue by doing this , uses: SamKirkland/FTP-Deploy-Action@v4.3.4 with: server: "Server Host" username: "FTP UserName" password: "FTP password" protocol: ftps

thorin87 commented 4 months ago

I have the same issue, in my case action is failing when trying to upload empty files. Verbose log level shows wrong file size (modulo.js should have 0 bytes, while it's reported with exactly the same size as previous file):

 uploading "catalog/view/javascript/jquery/owl.carousel/docs_src/data/options.json"
> EPSV
< 229 Extended Passive mode OK (|||64656|)
> STOR catalog/view/javascript/jquery/owl.carousel/docs_src/data/options.json
< 150 Accepted data connection
Uploading to 128.204.218.115:64656 (TLSv1.3)
upload progress for "catalog/view/javascript/jquery/owl.carousel/docs_src/data/options.json". Progress: 0 bytes of 37002992 bytes
upload progress for "catalog/view/javascript/jquery/owl.carousel/docs_src/data/options.json". Progress: 7655 bytes of 37010647 bytes
< 226-File successfully transferred
< 226 0.000 seconds (measured here), 32.89 Mbytes per second
  file uploaded
uploading "catalog/view/javascript/jquery/owl.carousel/docs_src/helpers/modulo.js"
> EPSV
< 229 Extended Passive mode OK (|||63597|)
> STOR catalog/view/javascript/jquery/owl.carousel/docs_src/helpers/modulo.js
< 150 Accepted data connection
Uploading to 128.204.218.115:63597 (TLSv1.3)
upload progress for "catalog/view/javascript/jquery/owl.carousel/docs_src/helpers/modulo.js". Progress: 0 bytes of 37010647 bytes
upload progress for "catalog/view/javascript/jquery/owl.carousel/docs_src/helpers/modulo.js". Progress: 0 bytes of 37010647 bytes
> QUIT
----------------------------------------------------------------
--------------  🔥🔥🔥 an error occurred  🔥🔥🔥  --------------
----------------------------------------------------------------
----------------------------------------------------------------
----------------------  full error below  ----------------------
----------------------------------------------------------------
Error: Server sent FIN packet unexpectedly, closing connection.
    at TLSSocket.<anonymous> (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/v4.3.5/dist/index.js:5109:56)
    at TLSSocket.emit (node:events:531:35)
    at endReadableNT (node:internal/streams/readable:1696:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Error: Error: Server sent FIN packet unexpectedly, closing connection.