SamKirkland / ftp-deploy

Deploy websites over FTP with one command line
MIT License
89 stars 43 forks source link

Update `.ftp-deploy-sync-state.json` if settings are changed #16

Open christian-bromann opened 2 years ago

christian-bromann commented 2 years ago

Hey,

I was using ftp-deploy through SamKirkland/FTP-Deploy-Action and had the situation that ftp-deploy-sync-state.json was created before I got my settings right. I missed to initiate a submodule directory so the action was thinking that the folder doesn't exist anymore and tried to remove it. I canceled the action but it appears that the state was captured in the sync state. After I found out about it and I removed it from the remote end my exclude property was acknowledged and everything was working fine. Due to SamKirkland/FTP-Deploy-Action#205 I was thinking the whole time it was something wrong on my end.

Not sure what would be the best solution here. Maybe the exclude check needs to be implemented at the FTP operation level and not sometime before. Or changes to the state file should be applied after all operations successful ran.

What do you think?