SamKirkland / ftp-deploy

Deploy websites over FTP with one command line
MIT License
89 stars 43 forks source link

Add support for syncing file modes #19

Open timthelion opened 2 years ago

timthelion commented 2 years ago

See: https://github.com/SamKirkland/FTP-Deploy-Action/issues/209

timthelion commented 2 years ago

Thank you for the code review. I'm a total outside when it comes to nodejs so I've made all the changes except the try..catch one because I'm not sure how to do it correctly.

timthelion commented 2 years ago

Hi, unfortunately I don't have time to redo this pull request with the better design. Should I close this?

In the mean time, you can use my fork ex: https://github.com/vegan-buddies/vegan-buddies/blob/20e437da95379930c7dd05cecd87f6fe1801fee0/.github/workflows/website.yml#L34

ihardz commented 10 months ago

@SamKirkland , Could you please take a look at the PR now. Thanks