search

SamProell / yarppg

Yet another implementation of remote photoplethysmography (rPPG) in Python
MIT License
51 stars 13 forks source link

Update filters.py #14

Closed s-celles closed 8 months ago

SamProell commented 8 months ago

I honestly appreciate your effort to contribute to this project. However, it looks like this PR only introduces some formatting changes, which I do not feel the need to introduce. The whole project uses 80 characters line length, which these changes do not comply with.

I am open to discuss switching to black or ruff-formatter for this project, and do some other "housekeeping" that might be necessary for this project, though :)

s-celles commented 8 months ago

That was just to let you know that

app = pg.QtGui.QApplication([])

raised

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'pyqtgraph.Qt.QtGui' has no attribute 'QApplication'. Did you mean: 'QGuiApplication'?

Formatting is just a detail but it's more pleasant to read code well formatted. I didn't know ruff-formatter. Thanks.

SamProell commented 8 months ago

oh i see, thank you @scls19fr ! Thanks for pointing this out. Probably, a version issue with pyqtgraph, as this did work before. I'll try to look into this on the weekend.