search

SamProf / MatBlazor

Material Design components for Blazor and Razor Components
http://www.matblazor.com
MIT License
2.84k stars 384 forks source link

Support all Material Icons #868

Open vankampenp opened 3 years ago

vankampenp commented 3 years ago

Describe the feature request The Google Material Design Icon collection is larger than the one currently supported in MatBlazor. It would be much more convenient if MatBlazor would support the whole set. https://fonts.google.com/icons All Google icons exist in five different versions, Outlined, Filled, Rounded, Sharp and Two Tone.

Expected behavior The current icon list is a wide collection of icon's, but not complete. Perhaps it is complete, but just a documentation issue. For example the Eco icon is not present on the documentation page, but it does work. I suggest to refer to the google site, rather than listing a subset of icons.

MatBlazor has a selection that are available in Outlined. These can be invoked by puting _outline after the icon name, i.e. delete and delete_outline. But for example "question_answer_outline" is not listed in the documentation (question_answer is), but renders as the Filled question_answer icon, rather than the outline version. The outline version is not in the list on matblazor.com/icon. It seems that when the outline version is not available on the documentation, it is rendered as the filled icon.

Expected 1) MatBlazor refers to a Google font icon source, and all icons in that source are available. Expected 2) All versions are supported for all icons, either by adding _outline, _fill, _round, _sharp or _twotone at the end of the icon, or by adding an extra Version parameter. The versions of the icons should not have to be shown in the list, but they should all be available with a consistent naming style.

enkodellc commented 3 years ago

@vankampenp Why don't you just implement it when you need it? You are assuming everyone who uses MatBlazor wants to use the Google font icons. I use FontAwesome so if MatBlazor used Google Font Icons then it would have additional unused resources. Just my opinion.

vankampenp commented 3 years ago

@enkodellc it is allready implemented here: https://www.matblazor.com/Icon These are the Google font icons, just not all

enkodellc commented 3 years ago

I will have to defer to @SamProf on this one.

Also Related to #732.