search

SamSaffron / MiniProfiler

A simple but effective mini-profiler for ASP.NET MVC, ASP.NET and Ruby.
http://miniprofiler.com
1.05k stars 221 forks source link

Fix redis spec dependency on array order #126

Closed felixbuenemann closed 11 years ago

felixbuenemann commented 11 years ago

On my system redis would return ['ABC', 'XYZ'] instead of ['XYZ', 'ABC'] which should still fit the requirement of the failing spec.

felixbuenemann commented 11 years ago

Btw. on occasion the timing specs fail for me, because they take 1ms longer than expected (1001 vs. 1000ms), I guess the specs should leave a minimal margin in that regard.

SamSaffron commented 11 years ago

completely fine to add that margin to the spec

felixbuenemann commented 11 years ago

@SamSaffron Yes, it's magic: https://github.com/dchelimsky/rspec/blob/master/lib/spec/matchers/match_array.rb#L69

SamSaffron commented 11 years ago

good to know ... thanks !