search

SamSaffron / MiniProfiler

A simple but effective mini-profiler for ASP.NET MVC, ASP.NET and Ruby.
http://miniprofiler.com
1.05k stars 221 forks source link

MiniProfiler requires JQuery #170

Closed mipearson closed 11 years ago

mipearson commented 11 years ago

This is cheeky, I know. Bloody cheeky. I'm not gonna be offended if this gets closed as WONTFIX.

This is an exploratory feature request more than anything else: can we make a version of MiniProfiler that doesn't need JQuery to do its rendering?

Asking as we're phasing out our JQuery / Rails-UJS stuff in favour of Angular, and MiniProfiler is the only thing left that uses JQuery.

SamSaffron commented 11 years ago

I think @mjibson has a branch that uses EJS, totally fine for a pull request that nukes current jquery tmpl in favor of EJS

Giving up jQuery.ajax is a big ask though.

maddyblue commented 11 years ago

This branch uses underscore.js for templating. MiniProfiler uses it for lots of other stuff, though. But I'm confused why this matters. You can safely remove jQuery from your project and MiniProfiler will load its own version if it needs to, unless I misunderstand something.

mipearson commented 11 years ago

Interesting! Less relevant to us now as we've restricted Angular to certain parts of the site & JQuery others.