SamSaffron / MiniProfiler

A simple but effective mini-profiler for ASP.NET MVC, ASP.NET and Ruby.
http://miniprofiler.com
1.05k stars 221 forks source link

Unnecessary newline inject #180

Closed miharekar closed 3 years ago

miharekar commented 11 years ago

I use rails 4 and rack-mini-profiler. I have a sticky footer so this issue is apparent to me and probably not everybody else. It seems to me that MiniProfiler injects itself before </body> and above all the scripts and divs it also injects an empty line:

screen shot 2013-08-05 at 21 24 05

Now this is not a big issue since I only use this gem in development but it sure is annoying to have whitespace under the sticky footer. I was losing my mind before I figured out what is causing it :smile:

chrislloyd commented 11 years ago

+1 on this issue. It prevents us from using it in production (in a subset of requests of course).

teoulas commented 11 years ago

I've seen this too, on Rails 3.2. There's an open pull request that fixes this https://github.com/SamSaffron/MiniProfiler/pull/190