Closed yellis closed 10 years ago
I really like this but we are in a huge pickle. we are transitioning to https://github.com/miniprofiler and are already quite diverged
@dixon @mjibson what do you want to do here, how far are we from shutting down this repo?
@SamSaffron If it were me, I'd request that @yellis (hi Yaakov) port this to the new-style dotnet repo at https://github.com/MiniProfiler/dotnet, which @dixon has updated with the new format. I would recommend against accepting any PRs to dotnet on this repo, and closing it as soon as possible. (Ruby is, obviously, a different story.)
@mjibson ruby has a much easier selling point here : https://github.com/SamSaffron/MiniProfiler/tree/master/Ruby
yeah ... I really want to shut down this repos asap and get the ruby port to use miniprofiler/ui ...
If you've already moved the ruby repo, what is preventing immediate shutdown of this one with a similar redirect notice?
@mjibson ... waiting for @dixon to make the call
I will give a shot at porting this to the new repo.
Though if this repo is going to stay for ruby (did I get that right?), then all of the logic in the less/css/js file updates (the core of the pr anyway) should still work. On Oct 4, 2013 5:26 AM, "Sam" notifications@github.com wrote:
@mjibson https://github.com/mjibson ... waiting for @dixonhttps://github.com/dixonto make the call
— Reply to this email directly or view it on GitHubhttps://github.com/SamSaffron/MiniProfiler/pull/196#issuecomment-25672798 .
nope this repo is going to die, it will not be used for anything, the ruby port will move the the new UI as soon as someone (probably me) moves it.
On Fri, Oct 4, 2013 at 1:02 PM, Yaakov Ellis notifications@github.comwrote:
I will give a shot at porting this to the new repo.
Though if this repo is going to stay for ruby (did I get that right?), then all of the logic in the less/css/js file updates (the core of the pr anyway) should still work. On Oct 4, 2013 5:26 AM, "Sam" notifications@github.com wrote:
@mjibson https://github.com/mjibson ... waiting for @dixon< https://github.com/dixon>to make the call
— Reply to this email directly or view it on GitHub< https://github.com/SamSaffron/MiniProfiler/pull/196#issuecomment-25672798>
.
— Reply to this email directly or view it on GitHubhttps://github.com/SamSaffron/MiniProfiler/pull/196#issuecomment-25673699 .
I created two new pull requests (one for dotnet and on for ui) in the new project. Both are referenced above.
I am fine with that, the ruby code is already gone.
On Fri, Oct 4, 2013 at 12:08 PM, Matt Jibson notifications@github.comwrote:
If you've already moved the ruby repo, what is preventing immediate shutdown of this one with a similar redirect notice?
— Reply to this email directly or view it on GitHubhttps://github.com/SamSaffron/MiniProfiler/pull/196#issuecomment-25672363 .
This is in response to Issue #194.
RenderPosition
values:BottomLeft
andBottomRight
(kept the existingLeft
andRight
the same - default is to Top, no reason to introduce legacy issues).