search

SamSaffron / fast_stack

MIT License
20 stars 3 forks source link

Support Ruby profiling on Windows #4

Closed lowjoel closed 9 years ago

lowjoel commented 9 years ago

:)

I have not tested this on Linux, since I'm currently on a Windows machine, but it should work.

It might concern you that I'm using SIGINT on Windows, but on the MSVC runtime (which Mingw uses too) SIGINT is not used by the system. I cannot use SIGALRM because Windows does not have that signal defined, and attempting to use it would cause a parameter validation error in the runtime.

capture

lowjoel commented 9 years ago

@tgxworld in case you're interested in how I did it...

SamSaffron commented 9 years ago

I am fine to merge this, but do you mind taking over publishing gems here, doing the multi build with windows kind of scares me.

On Tue, Aug 4, 2015 at 4:19 PM, Joel Low notifications@github.com wrote:

@tgxworld https://github.com/tgxworld in case you're interested in how I did it...

— Reply to this email directly or view it on GitHub https://github.com/SamSaffron/fast_stack/pull/4#issuecomment-127491666.

lowjoel commented 9 years ago

Thanks Sam, what do you mean by publishing? As in pushing them to rubygems?

SamSaffron commented 9 years ago

Yeah, I can give you commit on the repo + add you to authors and you can take care of publishing this thing :) plus be a co maintainer, keep in mind on 2.2 I usually use stack prof in raw mode.

On Wed, Aug 5, 2015 at 2:44 PM, Joel Low notifications@github.com wrote:

Thanks Same, what do you mean by publishing? As in pushing them to rubygems?

— Reply to this email directly or view it on GitHub https://github.com/SamSaffron/fast_stack/pull/4#issuecomment-127845287.

lowjoel commented 9 years ago

Sure.

I'd use stackprof, but there seems to be even more that I need to wire up for Windows to get rack-mini-profiler working, so I figured I should get this working first since it's a simpler implementation.

Maybe in future I'll be able to port stackprof to Windows too...

SamSaffron commented 9 years ago

can you pm me your email address my twitter handle is @samsaffron, that way I can give you ownership on the gem? I just added you as collaborator, if you are 100% this all works please merge.

On Wed, Aug 5, 2015 at 4:35 PM, Joel Low notifications@github.com wrote:

Sure.

I'd use stackprof, but there seems to be even more that I need to wire up for Windows to get rack-mini-profiler working, so I figured I should get this working first since it's a simpler implementation.

Maybe in future I'll be able to port stackprof to Windows too...

— Reply to this email directly or view it on GitHub https://github.com/SamSaffron/fast_stack/pull/4#issuecomment-127889650.

lowjoel commented 9 years ago

My email is the same as the one on my profile (should be publicly displayable)

SamSaffron commented 9 years ago

np, you are an owner on fast_stack now !

On Thu, Aug 6, 2015 at 5:56 PM, Joel Low notifications@github.com wrote:

My email is the same as the one on my profile (should be publicly displayable)

— Reply to this email directly or view it on GitHub https://github.com/SamSaffron/fast_stack/pull/4#issuecomment-128283010.

lowjoel commented 9 years ago

@SamSaffron can you enable Travis for this repo? I'd want to get it working.

Also, AppVeyor for Windows once I get around to doing that...

EDIT: I enabled AppVeyor, once I get consistent Ruby builds I'd push a config for that there.

SamSaffron commented 9 years ago

Go for it :) I thought you have commit ...

On Sat, Oct 17, 2015 at 1:07 PM, Joel Low notifications@github.com wrote:

@SamSaffron https://github.com/SamSaffron can you enable Travis for this repo? I'd want to get it working.

Also, AppVeyor for Windows once I get around to doing that...

— Reply to this email directly or view it on GitHub https://github.com/SamSaffron/fast_stack/pull/4#issuecomment-148877802.

lowjoel commented 9 years ago

It appears that Travis doesn't let me activate it for a repo unless I have admin, so I don't get to turn it on.

Hang on, it's already enabled: https://travis-ci.org/SamSaffron/fast_stack

SamSaffron commented 9 years ago

hmmm it appears to be active on fast stack ...

On Mon, Oct 19, 2015 at 12:08 PM, Joel Low notifications@github.com wrote:

It appears that Travis doesn't let me activate it for a repo unless I have admin, so I don't get to turn it on.

— Reply to this email directly or view it on GitHub https://github.com/SamSaffron/fast_stack/pull/4#issuecomment-149071999.

lowjoel commented 9 years ago

Yup, it is, I’ll work on it.