search

SamSaffron / fast_stack

MIT License
19 stars 3 forks source link

Can rake-compiler be a development dependency? #5

Closed joshuaflanagan closed 9 years ago

joshuaflanagan commented 9 years ago

I just added the flamegraph gem to my project, and noticed that rake-compiler was brought in via fast_stack.

I'm not familiar with how rake-compiler works, but I get the feeling it should only be needed by the fast_stack gem authors, which should make it a good candidate for add_development_dependency in the gemspec. It would be nice to reduce the gem footprint for anyone pulling in this fast_stack.

SamSaffron commented 9 years ago

Interesting can you try removing it and see if the gem installs right, I though it is required for the compilation phase cause we do not ship binaries

On Tuesday, August 25, 2015, Joshua Flanagan notifications@github.com wrote:

I just added the flamegraph gem to my project, and noticed that rake-compiler was brought in via fast_stack.

I'm not familiar with how rake-compiler works, but I get the feeling it should only be needed by the fast_stack gem authors, which should make it a good candidate for add_development_dependency in the gemspec. It would be nice to reduce the gem footprint for anyone pulling in this fast_stack.

— Reply to this email directly or view it on GitHub https://github.com/SamSaffron/fast_stack/issues/5.