SamSaffron / flamegraph

Flamegraph profiling support for Ruby 2.0
MIT License
382 stars 36 forks source link

Ability to hide and unhide some gems #17

Open agrimm opened 8 years ago

agrimm commented 8 years ago

The overall problem I'm facing is having information overload associated with flamegraphs: http://stackoverflow.com/questions/35855922/dealing-with-information-overload-for-rack-mini-profiler-flamegraph

One approach for dealing with this (not mentioned in the SO question) may be to have the ability to click on a gem to hide (or unhide) gems. For example, I'd click on the "journey-1.0.4" gem and then the nodes for that would disappear. It'd probably be something like #7 (interactive legend) except with a different trigger and a different effect, and possibly something for hiding or unhiding all third party gems.

SamSaffron commented 8 years ago

replied here:

http://community.miniprofiler.com/t/how-to-deal-with-information-overload-in-flamegraphs/437

open to adding more features

benoittgt commented 8 years ago

Thanks a lot Sam for this answer. You clarify some points of flamegraph.

etagwerker commented 5 years ago

@SamSaffron Thanks for your explanation! I like @agrimm's idea. If I was interested in adding this feature to hide some gems/paths from the flame graph, where could I start? Somewhere in this file: https://github.com/SamSaffron/flamegraph/blob/master/lib/flamegraph/renderer.rb?

SamSaffron commented 5 years ago

@etagwerker all the rendering is done in javascript, so you would look there... I am open to more features that add flexibility, but if you are looking for radical changes keep an eye on https://github.com/SamSaffron/flamegraph/pull/24 by @thisduck we plan to ship with multiple rendering engines soonish.