Closed thisduck closed 7 years ago
thanks for this! I like the changes but the UI needs to be a bit more polished, maybe have it default off for now just to get it merged in and then we can polish up the UI a bit.
On Sun, Apr 23, 2017 at 3:46 PM, Adnan Ali notifications@github.com wrote:
Hi @SamSaffron https://github.com/SamSaffron
I've made a few changes (demo in video link: https://drive.google.com/open?id=0B-8YziZr08bQaEF3VmNIQURFMWM ):
- Added the ability to color by gem or method via radio buttons, without having to refresh the page.
- Filter by width of frame (to get quick visibility on slower calls).
- Ability to see callee in addition of the backtrace in the modal.
- Zoom via click, instead of having to click and drag.
Would love your thoughts.
Additionally I'm working on getting filtering via method/gem, as well.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SamSaffron/flamegraph/issues/23, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAUXXnYxibABWlxD5vFc8eDw2tT9zDOks5ry9TfgaJpZM4NFkFs .
Yup! I will polish things up more and open a pull request soon! Just wanted to run it by you first.
I got filtering via gem working as well.
@SamSaffron Are you okay with adding bootstrap or some other css/js library to do things like tooltips and nicer looking UI?
Hi @SamSaffron
I've made a few changes (demo in video link: https://drive.google.com/open?id=0B-8YziZr08bQaEF3VmNIQURFMWM ):
Would love your thoughts.
Additionally I'm working on getting filtering via method/gem, as well.