make raw cache data accessible.

yudai09 commented 8 years ago

I want to access raw hash data so that serialize it and store into a file.

Seberius commented 8 years ago

Hello, Thank you for your interest in contributing to the library. I will leave it up to @SamSaffron to decide whether or not to accept this feature. I would wait to see what that decision is before working on my suggestions below.

The pull request will need to be revised as it is incomplete for a new method. You will need to add:

[ ] TTL cache support - Attempts are made to keep the methods between the LRU and TTL cache equivalent where possible. Note that while the methods need to be named the same, the instance variables are named differently. You will also need to consider how to handle the TTL data hash.
[ ] ThreadSafe support - Please refer to lib/lru_redux/util/safe_sync.rb for examples. You may also need to add support to lib/lru_redux/util/safe_sync_jruby.rb if tests fail (JRuby) without it.
[ ] Test coverage - Appropriate tests should be added. The tests should demonstrate that both the read and write have expected results. Please refer to test/cache_test.rb for examples.

SamSaffron commented 8 years ago

Agree with all @Seberius in addition, this change feels a bit too wide to be allowed, instead supporting a to_json and from json or stuff like that feels more like the correct level of abstraction.

yudai09 commented 8 years ago

I'm sorry. I overlooked to_a(). It's enough for my usage.

SamSaffron / lru_redux

make raw cache data accessible. #14