Add shadowdom, add data-button-color and data-anon, reset dialog cach…

SamSamskies / nostr-zap

Zap any Nostr npub or note from anywhere.

MIT License

78 stars 14 forks source link

Add shadowdom, add data-button-color and data-anon, reset dialog cach… #24

Closed brugeman closed 4 months ago

brugeman commented 4 months ago

…e on param change:

creating the styles and dialog in a shadowdom now to avoid mixing styles with the parent page
we needed to customize the button colors
added data-anon=true to make sure it doesn't try to access window.nostr - with nostr-login it causes another modal to open which is quite confusing

SamSamskies commented 4 months ago

switching to using shadow dom would be a breaking change. i know some people are overriding the styles and upgrading to this latest version would break things for them. can you think of a way to make using the shadow dom opt in? maybe adding a data attribute to the script tag?

SamSamskies commented 4 months ago

let's forget about making the shadow dom opt in. it's probably better that's the default. i'll just bump the version to v1.0.0.

let me test out your PR a bit today. if i don't find any issues, i'll merge and deploy it today.