Request: Fetch password protected podcasts

d3545t3r commented 1 year ago

Describe the bug

I host a few podcast episodes, which are accessible through their own subdomain and are accessible through

BasicAuthorization via Nginx HTTP Basic Authentication

With various podcast apps (AntennaPod, PodcastAddict, etc.) it is possible to pass username and password and include these episodes.

I have already tried to do this through

https://<USERNAME>:<PASSWORD>@<URL TO THE RSS FEED>

but it doesn't seem to work in Podfetch.

It would be nice if this could be implemented, even though I think it is a very special niche case.

Reproduction

https://:@

System Info

System:
    OS: Linux 5.15 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (4) arm ARMv7 Processor rev 5 (v7l)
    Memory: 156.01 MB / 999.02 MB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 19.9.0 - /usr/local/bin/node
    npm: 9.6.3 - /usr/local/bin/npm

Used Package Manager

npm

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

SamTV12345 commented 1 year ago

Thanks. I'll implement that. Are the episodes itself also secured by basic authentication? If yes, are the episodes also secured by the same basic auth user as the rss feed?

SamTV12345 commented 1 year ago

I added it to the main branch. Could you try again?

d3545t3r commented 1 year ago

Doesn't seem to work...

I get the following error Message

thread 'thread 'actix-rt|system:0|arbiter:3actix-rt|system:0|arbiter:0' panicked at '' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidStartTagcalled `Result::unwrap()` on an `Err` value: InvalidStartTag', ', src/controllers/podcast_controller.rssrc/controllers/

SamTV12345 commented 1 year ago

Could you give me a guide on how to get started with a proxy with basic auth? I think I need to reproduce this locally to get a chance to implement this succesfully.

d3545t3r commented 1 year ago

Unfortunately I don't have time right now, but I'll set you up with a test setup this weekend so you can try out your changes.

I hope this will help you.

d3545t3r commented 1 year ago

Seems to work now. Thanks a lot. I can add my self hosted podcasts with

https://<USERNAME>:<PASSWORD>@<URL TO THE RSS FEED>

SamTV12345 commented 1 year ago

Nice. Seems like I got every occasion where the podcast server reaches out to the RSS feed.

SamTV12345 / PodFetch