search

SamTheBlow / grand-strategy-game

A grand strategy game made in Godot.
MIT License
5 stars 4 forks source link

Naming inconsistency in raw data parser scripts #186

Closed SamTheBlow closed 4 days ago

SamTheBlow commented 1 month ago

Some of them are called "x_to_json", and some (more recently) are called "x_to_dict". I do think it's more correct to use the term "dict" rather than "json" because the scripts convert objects from/to raw data, not specifically JSON data. So I guess rename the scripts to not use the term "json".

SamTheBlow commented 3 weeks ago

There's now a third contestant for parser class names: "x_to_raw". :skull:

I guess I'll have to keep experimenting until I find something that feels right... Does any idea come to your mind, person reading this..?

SamTheBlow commented 4 days ago

I like x_to_raw for now, and we can also use x_to_raw_array or x_to_raw_dict to be more specific. I renamed files and classes that shouldn't use the term "JSON", so I'm closing the issue for now