Peer to peer code review

SamTush / toDo-list

In this project, I build a simple HTML list of To Do tasks. The list will be styled according to the specifications listed later in this lesson. This simple web page is built using webpack and served by a webpack dev server.

MIT License

3 stars 0 forks source link

Peer to peer code review #4

Open Tshobohwa opened 1 year ago

Tshobohwa commented 1 year ago

Hi @SamTush 👋 , You have done a good job so far, however, there are still some issues you need to fix but you're almost there.

Highlights 💯

Nice user interface
Good use of classes for encapsulation

Changes required ♻️

https://github.com/SamTush/toDo-list/blob/cab18681c80c2743e32898e596f4e16c0af72d7b/src/modules/Apps.js#L149-L161

[x] kindly fix the delete function, when the user tries to remove one task, it happens some times that all the tasks are deleted.

Tracy-miranja commented 1 year ago

Hi @SamTush

Highlights

Your Github flow is great!
Your contact form validation and data retrieval is working perfectly.

Suggestions

Kindly separate CSS file from HTML file.
Kindly change the color of your logo to follow the design guidelines in Figma.
When you exit the menu, kindly make sure the background is also gone with it.

Cheers! :star: