SamVerschueren / clinton

Project style linter
MIT License
122 stars 9 forks source link

fix(pkg-normalize): if bugs, homepage, repository has object #51

Closed Scrum closed 8 years ago

SamVerschueren commented 8 years ago

Care to add a test for this?

Scrum commented 8 years ago

yep, i forgot.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 79.088% when pulling 04a98cb25b4c3fa7df14f28a448b977910a3f14f on GitScrum:fix-condition into 3778eba84859fca25182a89ec383bce0de44e96c on SamVerschueren:master.

Scrum commented 8 years ago

@SamVerschueren ping

SamVerschueren commented 8 years ago

Thanks @GitScrum, I believe if you address my comment, it's good to go :)!

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.006%) to 79.245% when pulling f786d16bb7729be310fabef7d851973c46838346 on GitScrum:fix-condition into 3778eba84859fca25182a89ec383bce0de44e96c on SamVerschueren:master.

SamVerschueren commented 8 years ago

Thanks for the effort @GitScrum ! 🍻

Scrum commented 8 years ago

@SamVerschueren Always ready if something else needs to be done it develops. Thank you for this package, he's cool.

SamVerschueren commented 8 years ago

Thanks for the offer. Always happy to receive PR's for issues in the issue tracker. Feel free to suggest new rules or improvements as well!

Scrum commented 8 years ago

@SamVerschueren when can we expect the updates to npm ?

SamVerschueren commented 8 years ago

Wanted to solve #45 first but if you really need the changes I can do a release right now. Just let me know.

Scrum commented 8 years ago

I forgot the project I needed it )) is not in a hurry, thank you.