search

SamVerschueren / clinton

Project style linter
MIT License
122 stars 9 forks source link

Bump code coverage to 95+ #53

Closed SamVerschueren closed 7 years ago

SamVerschueren commented 8 years ago

Currently the code coverage is pretty low (79%). I'd like to have it at least 90%, if possible even higher. The major problem is that currently the fix methods aren't being tested. How should we test them? I believe the best thing we can do is to copy over the files to a temporary directory and fix them over there. Might be hard to set up though so have to investigate first.

sindresorhus commented 8 years ago

How should we test them?

Return the original content and the fixed content of a file in the API. No need for temp files then.

SamVerschueren commented 8 years ago

Thanks for the feedback. Will look into that option.

SamVerschueren commented 7 years ago

With f9ad52c156ad9fb0ecb1cda524400eeac04cbd18 came the possibility to test fixers. We've now reached a code coverage of 92%.

I still think we have some low hanging fruit to increase this even more.