search

SamVerschueren / dynongo

MongoDB like syntax for DynamoDB
MIT License
58 stars 16 forks source link

Expose all TypeScript typings #71

Closed SamVerschueren closed 5 years ago

SamVerschueren commented 5 years ago

Currently, the types for Scan and Query are not exposed in the main file. This means that you have to import them via import {Scan} from 'dynongo/src/lib/methods'; (or something). What we want is to be able to do import {Scan} from 'dynongo';.

MrCube42 commented 5 years ago

@SamVerschueren Just Query and Scan or everything under /methods? Do you also want to shortcut inside of the lib which means I would also add index files in subfolders? Otherwise you just have to reexport in dynogo/index.ts. I can do this.

bartcallant commented 5 years ago

PR: https://github.com/SamVerschueren/dynongo/pull/72

Found one naming collision.

bartcallant commented 5 years ago

@devinmotion sorry, did not see your comment. I had already done something like this some time ago, just needed to finish it..

MrCube42 commented 5 years ago

@bartcallant No problem. First come, first serve ;) Nicely done 👍 . I just left a comment to your PR. You may consider it.