search

SamVerschueren / gulp-cordova-build-android

Gulp plugin for building an android Cordova project
MIT License
14 stars 10 forks source link

Allow creating unsigned release APKs #2

Closed DavidThomasSL closed 9 years ago

DavidThomasSL commented 9 years ago

I've added the ability to create unsigned release APKs as I believe this to be a fairly common use case. Users may want to do the signing process separately to their standard build, so they do not have to store their passwords in their build file, which will likely be in source control.

I'll be working with Blackberry fairly soon so am happy to make the same change in gulp-cordova-build-bb10 if required.

SamVerschueren commented 9 years ago

Hi @DavidThomasSL

First of all, thanks for the PR. I get the idea but will probably refactor it a little bit. In gulp-cordova-build-bb10 a release boolean property is passed in via the options object indicating if the *.bar file is for release or not. It would be more consistent I guess if it was passed in via the options object.

DavidThomasSL commented 9 years ago

Hi @SamVerschueren, Thanks for your response. I'll have a look at doing the refactor for you if you like. I can put the release option onto the options object. I agree that this will make it more consistent with the Blackberry implementation. This will mean changing the creation of the release-signing.properties file, which will change the behaviour of the plugin in the edge case where users are trying to add other properties to the release-signing.properties file. I'll submit another pull request to see what you think.

SamVerschueren commented 9 years ago

Closing this one in favour of PR https://github.com/SamVerschueren/gulp-cordova-build-android/pull/3