search

SamVerschueren / vscode-yo

Yeoman plugin for VS Code
MIT License
87 stars 15 forks source link

Fix issues with being able to develop on vscode-yo (fixes #19) #20

Closed bpasero closed 8 years ago

bpasero commented 8 years ago

With these changes I can "npm run compile" from the extension and also run it :)

SamVerschueren commented 8 years ago

Hi @bpasero, can you explain in more detail what is being fixed by this PR? I'm afraid I don't understa entirely :).

bpasero commented 8 years ago

@SamVerschueren I tried to run the extension after checking out from GH. There are two issues for doing so:

1.) npm run compile will not work because typescript is no longer a dependency of the vscode module. If you "git clean -xfd" and then "npm install" again you will see the same issue. Latest extensions generated from "yo code" already follow the pattern that typescript is an explicit dependency of the extension itself. With this you can even target TS 1.7 if you want (e.g. benefit from asnc/await!).

2.) lodash is a dependency in your code that is not listed in package.json

SamVerschueren commented 8 years ago

Alright, good catch! Thanks!