search

SamVerschueren / vscode-yo

Yeoman plugin for VS Code
MIT License
87 stars 15 forks source link

Handle invalid generatorVersion value #36

Closed aguerotSOVINTY closed 8 years ago

aguerotSOVINTY commented 8 years ago

Do not handle generators that can't provide a valid generatorversion (package.config misconfigured) see https://github.com/SamVerschueren/vscode-yo/issues/35 for details

SamVerschueren commented 8 years ago

Fix inconsistent tabs/spaces. At the moment it's a combo. EditorConfig fixes this as well.

SamVerschueren commented 8 years ago

Thanks for the PR. Added some notes that should be fixed first. After that it's good to merge :).

aguerotSOVINTY commented 8 years ago

Thanks for the feedback, I’ll install the extension suggested for .editorconfig and correct the issues you listed.

SamVerschueren commented 8 years ago

Added some notes :). Please stick at the original issue. I would like to review them separately.

PS. I'm glad your first PR/GH contribution was on one of my projects! :+1:

SamVerschueren commented 8 years ago

Sorry for giving you so much feedback :s. Just ping me back with a comment if you did these changes. I don't get a notification if you commit something new.

aguerotSOVINTY commented 8 years ago

Hi,

Changes based on your feedback committed.

From: Sam Verschueren [mailto:notifications@github.com] Sent: Tuesday, March 1, 2016 11:25 To: SamVerschueren/vscode-yo vscode-yo@noreply.github.com Cc: Anthony Guérot aguerot@sovinty.com Subject: Re: [vscode-yo] Handle invalid generatorVersion value (#36)

Sorry for giving you so much feedback :s. Just ping me back with a comment if you did these changes. I don't get a notification if you commit something new.

— Reply to this email directly or view it on GitHubhttps://github.com/SamVerschueren/vscode-yo/pull/36#issuecomment-190651820.

SamVerschueren commented 8 years ago

Thanks for the PR! Merged :beers:

aguerotSOVINTY commented 8 years ago

Glad I could help gg