SamVerschueren / vscode-yo

Yeoman plugin for VS Code
MIT License
87 stars 15 forks source link

package.json is missing postinstall script #38

Closed bpasero closed 8 years ago

bpasero commented 8 years ago

Any reason why the postinstall script is not configured for package.json:

"postinstall": "node ./node_modules/vscode/bin/install"

If you do not use this, otherwise the vscode module cannot be resolved because vscode.d.ts is missing unless you have this postinstall script.

SamVerschueren commented 8 years ago

You're right. It's possibly because in the beginning it wasn't necessary, right?

bpasero commented 8 years ago

@SamVerschueren yes for vscode@0.10.x it is not but I noticed that you use "*" as dependency and anyone checking out the project fresh and doing a npm install will get compile errors due to that.

SamVerschueren commented 8 years ago

Fixed! Thanks @bpasero

bpasero commented 8 years ago

Nice :+1: