search

SamVerschueren / vscode-yo

Yeoman plugin for VS Code
MIT License
87 stars 15 forks source link

Adapter#prompt doesn't return a promise #42

Closed jrieken closed 7 years ago

jrieken commented 7 years ago

I am running in a type error as shown below and believe that's because vscode-yo doesn't return a promise from prompt but yeoman-generator expects that

Uncaught Exception:  TypeError: Cannot read property 'then' of undefined
TypeError: Cannot read property 'then' of undefined
    at Base.prompt (/Users/jrieken/Code/collab/generator-code-javascript/node_modules/yeoman-generator/lib/base.js:240:44)
    at prompting (/Users/jrieken/Code/collab/generator-code-javascript/generators/app/index.js:111:21)
    at Object.<anonymous> (/Users/jrieken/Code/collab/generator-code-javascript/node_modules/yeoman-generator/lib/base.js:439:23)
    at /Users/jrieken/Code/collab/generator-code-javascript/node_modules/run-async/index.js:26:25
jrieken commented 7 years ago

The generator in question: https://github.com/Microsoft/vscode-generator-code-javascript

SamVerschueren commented 7 years ago

Thanks for reporting! I will look into it when I find some time.

jrieken commented 7 years ago

Seems like yeoman now really depends on promises being passed around...

jrieken commented 7 years ago

yeah... https://github.com/yeoman/generator/releases/tag/v0.23.0

jdubois commented 7 years ago

Same issue here, trying to use https://github.com/jhipster/generator-jhipster If you need some testing I can help (I'm the JHipster project lead)

SamVerschueren commented 7 years ago

Fixed in 0.9.0. Sorry for the delay, had some other priorities.