search

SamaCare / eng-practices

Samacare's Engineering Practices documentation
https://google.github.io/eng-practices/
Other
1 stars 0 forks source link

how to approach old files/tech debt – javascript, class components, antipatterns #2

Open mhammer708 opened 5 months ago

mhammer708 commented 5 months ago

in the past, there were guidelines around when we should replace these files but have these guidelines changed?


For example, if the author wants to reformat the whole file, have them send you just the reformatting as one CL, and then send another CL with their functional changes after that.
sidhuko commented 5 months ago

I think this aligns closer to smaller PR's. We've had some instances in the past where product asked for functionality and the conversion was also included in the ticket which causes issues in the functionality. I wouldn't be adverse to trying it this way.