search

Samagra-Development / Doc-Generator

Create PDFs from a variety of formats.
17 stars 45 forks source link

github action for build and test #139

Closed Tushar98644 closed 1 year ago

Tushar98644 commented 1 year ago

fixes #101

@radhay-1199 Kept the pipeline as default as it can be , awaiting your review for the specifications that need to be added

AnshulMalik commented 1 year ago

Thanks for the PR @Tushar98644 . Just a couple of things, can we update the branches to be Roadmap-2023? And we are using yarn instead of npm in this project, so that would also be preferred.

Tushar98644 commented 1 year ago

Thanks for the PR @Tushar98644 . Just a couple of things, can we update the branches to be Roadmap-2023? And we are using yarn instead of npm in this project, so that would also be preferred.

I have updated it from npm to yarn. For update the branch to Roadmap-2023, do you mean changing the source branch to Roadmap-2023?

AnshulMalik commented 1 year ago

For update the branch to Roadmap-2023, do you mean changing the source branch to Roadmap-2023?

Yes, I meant the source branch, which is currently main in the action file.

Tushar98644 commented 1 year ago

For update the branch to Roadmap-2023, do you mean changing the source branch to Roadmap-2023?

Yes, I meant the source branch, which is currently main in the action file.

Currently github does not allow the source branch to be changed after a pr is created , should I create a new pr?

AnshulMalik commented 1 year ago

@Tushar98644 this step is failing cp nest-cli.json dist/nest-cli.json

Tushar98644 commented 1 year ago

@Tushar98644 this step is failing cp nest-cli.json dist/nest-cli.json

I have removed that , that task was necessary if a build/dist was present , but there is no such folder

AnshulMalik commented 1 year ago

Lockfile needs to be updated @Tushar98644

Tushar98644 commented 1 year ago

Lockfile needs to be updated @Tushar98644

updated , now it works fine