Samagra-Development / Doc-Generator

Create PDFs from a variety of formats.
17 stars 46 forks source link

Detach app service from dev builds #151

Closed FirePing32 closed 1 year ago

FirePing32 commented 1 year ago

Nest app is now detached from dev builds and runs separately.

fixes:#148

CC: @yuvrajsab

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | ea29fbe0fd2639133f229eb36903ef933a2cd636 | .env.copy | [View secret](https://github.com/Samagra-Development/Doc-Generator/commit/ea29fbe0fd2639133f229eb36903ef933a2cd636#diff-de9d9bf13c34baa524517b6fa2e0e126R11) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

FirePing32 commented 1 year ago

Why is GitGuardian failing ? @yuvrajsab @ChakshuGautam

yuvrajsab commented 1 year ago

@FirePing32, It checks for any secret in the code base since .env.copy file contains a dummy HASURA_ADMIN_SECRET secret it is giving this warning. you can ignore this.

FirePing32 commented 1 year ago

@yuvrajsab Please merge.

yuvrajsab commented 1 year ago

@AnshulMalik please merge this.