search

Samagra-Development / Text2SQL

20 stars 11 forks source link

Delete the database from schema_holder table, mysql and postgres in case onboarding fails #47

Open suyashgautam opened 1 year ago

suyashgautam commented 1 year ago

Currently, if onboarding fails then in that case a record still persists in the schema_holder table. Also in case the file fails in between then the schema still persists in that particular database type. For example - I am onboarding a mysql database and schemaid is "abc" and the file failed while creating a table in that case a record will still be present in schema_holder table and also the mysql db where we are replicating the db.

Make code changes such that we could fix this issue.

Deekshithrathod commented 1 year ago

@suyashgautam I can work on this, feel free to assign the issue to me.

suyashgautam commented 1 year ago

Sure @Deekshithrathod , I have assigned this issue to you.

suyashgautam commented 1 year ago

Hi @Deekshithrathod any progress on this issue? We can discuss if you are facing any issues

Deekshithrathod commented 1 year ago

Started working today, I'll reach out if I face any roadblocks.

Updated: @suyashgautam I've asked for help in setting up the project on Discord 2 days ago. Can you take a look at it here?

Deekshithrathod commented 1 year ago

Hey @suyashgautam, I understand that you might be swamped with work. If you don't mind can you take a look at the message I left a message on discord yesterday? This is the message

suyashgautam commented 1 year ago

Hi @Deekshithrathod Hope you are doing well. I wanted to check any updates on this ticket?

Deekshithrathod commented 1 year ago

@suyashgautam Yes, I finally got help on Discord & set up the project on GitPod yesterday. Narrowed down the scope, i.e. figured out that the changes that need to be made might go here.

Since I'm new to Python, I'm trying to wrap my head around Quart (at least the basics) & make changes.

Is this blocking any other issues? I was planning to get to this today or tomorrow.

suyashgautam commented 1 year ago

@Deekshithrathod That is good to hear you are able to proceed forward. It's not a direct blocker but @goyalpramod is currently working on the testing framework where he is working on adding support for sqlite so if the schema is failing continuously Postgres will get cluttered. Please create a PR once it is done or you can discuss it on the discord if you are facing any issues.

Deekshithrathod commented 1 year ago

@suyashgautam You should un-assign me & give it to someone else. I didn't get time to get to it over the weekend & it seems like I'll be busy this week as well.