Samagra-Development / Text2SQL

20 stars 11 forks source link

Improvement of db_helper for sqlite support #52

Closed goyalpramod closed 1 year ago

goyalpramod commented 1 year ago

Earlier db_helper for sqlite support was storing the temporary db in the root directory. After this PR it will store the temporary db files in a temporary directory that can be deleted later.

Regex has also been improved in create_schema_for_db to take care of the case when semi-colon (;) may be present inside the query.

goyalpramod commented 1 year ago

@suyashgautam kindly review the changes whenever you get the time

suyashgautam commented 1 year ago

Merge this code as part of #53 Hence closing this ticket

suyashgautam commented 1 year ago

Merge this code as part of #53 Hence closing this ticket