Samagra-Development / WarpSQL

WarpSQL
https://samagra-development.github.io/WarpSQL/
Apache License 2.0
14 stars 29 forks source link

Add Disaster Recovery for AWS #105

Closed PiyushRaj927 closed 10 months ago

PiyushRaj927 commented 10 months ago

Related PR #22 This PR adds

DEMO LINK: https://drive.google.com/file/d/1PCPS44IseqJcQxAZVZjvAb-fTF6RiVrB/view?usp=sharing

singhalkarun commented 10 months ago

Hi @PiyushRaj927 I see ssh access has been added to the main Dockerfile. Since, it is something experimental in nature, can we have a separate Dockerfile with ssh access and keep the main WarpSQL image as it is. Once we have a solution on how to utilize SSH of the VM itself, we will anyways have to remove the ssh part from the Dockerfile.

You can create a folder in a similar manner how you've created for barman.

PiyushRaj927 commented 10 months ago

Hi @singhalkarun I've made the recommended changes. Please take a look and review them.

singhalkarun commented 10 months ago

Hi @PiyushRaj927 Functionally the code looks good. Merging it. Although feel there can be code cleaning that can be done which you can pick up.

e.g., you can use dynamic inventory to fetch addresses of machine while running ansible file instead of creating an inventory file during launching instances.