Closed PiyushRaj927 closed 10 months ago
Hi @PiyushRaj927 I see ssh access has been added to the main Dockerfile. Since, it is something experimental in nature, can we have a separate Dockerfile with ssh access and keep the main WarpSQL image as it is. Once we have a solution on how to utilize SSH of the VM itself, we will anyways have to remove the ssh part from the Dockerfile.
You can create a folder in a similar manner how you've created for barman.
Hi @singhalkarun I've made the recommended changes. Please take a look and review them.
Hi @PiyushRaj927 Functionally the code looks good. Merging it. Although feel there can be code cleaning that can be done which you can pick up.
e.g., you can use dynamic inventory to fetch addresses of machine while running ansible file instead of creating an inventory file during launching instances.
Related PR #22 This PR adds
README.md
reflecting the latest modifications.DEMO LINK: https://drive.google.com/file/d/1PCPS44IseqJcQxAZVZjvAb-fTF6RiVrB/view?usp=sharing