Samagra-Development / WarpSQL

WarpSQL
https://samagra-development.github.io/WarpSQL/
Apache License 2.0
16 stars 28 forks source link

warpsql: Pass citus extension from makefile. #16

Closed jayanth-kumar-morem closed 1 year ago

jayanth-kumar-morem commented 1 year ago
  1. Removed harcoded CITUS_VERSION from both the Dockerfiles.
  2. Passing the CITUS_VERSION from Makefile-s

Fixes: #15

ChakshuGautam commented 1 year ago

How does the Citus version map to the Postgres version? Is there always backward/forward compatibility?

jayanth-kumar-morem commented 1 year ago

Here's the log when we are building the image using the bitnami pg12 image.

We have a bitnami pg15 release recently, with that we are able to build the image successfully.

Screenshot 2023-04-23 at 8 31 18 PM
ChakshuGautam commented 1 year ago

@jayanth-kumar-morem Can we create a compatibility matrix first and then figure out how to build these images through CI?

I think we will have to create one for every Postgres version. For example pg12

TimescaleDB PgVector Citus Data PostGIS ZomboDB PLV8
TimescaleDB
PgVector
Citus Data
PostGIS
ZomboDB
PLV8
jayanth-kumar-morem commented 1 year ago

Alright @ChakshuGautam . Do you have any specific requirement to stick to pg12? If not, I would like to start checking the extensions compatibility with the latest pg15 and then pg12.

--- TimescaleDB PgVector Citus PostGIS ZomboDB PLV8
pg15 :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
pg12 :white_check_mark: :white_check_mark:
ChakshuGautam commented 1 year ago

Hey no. pg12 is just an example. The project where this is getting used is using pg15.

jayanth-kumar-morem commented 1 year ago

Ohh okay, sounds good

ChakshuGautam commented 1 year ago

Although the matrix is 3/4D and not 2D. There are interdependent compatibility issues also that want to call out so that the users can take a conscious decision when installing a version.

Let's track that matrix at a separate issue. Closing this one.