Samagra-Development / WarpSQL

WarpSQL
https://samagra-development.github.io/WarpSQL/
Apache License 2.0
16 stars 28 forks source link

Citus #3

Closed ChakshuGautam closed 1 year ago

ChakshuGautam commented 1 year ago

Every single issue should have the following

jayanth-kumar-morem commented 1 year ago

Hi @ChakshuGautam , I would like to take this one up, can you assign me to this

jayanth-kumar-morem commented 1 year ago

Thanks @ChakshuGautam , I have raised a PR #11

ChakshuGautam commented 1 year ago

Hey @jayanth-kumar-morem currently Citus and Timescale are not compatible - "Another time-partitioning extension for PostgreSQL is TimescaleDB. Unfortunately, Citus and TimescaleDB are currently not compatible." from this article. Can you also add a feature to disable TimescaleDB by default so the user has a choice to add it when needed?

Also added a checklist for this ticket. Please update the smoke tests for this addition. Thanks :)

jayanth-kumar-morem commented 1 year ago

Hi @ChakshuGautam ,

Could you share more details on the last point in the checklist, Build pipeline updates needed .

Also, To provide users with the option to enable or disable TimescaleDB by default, we can make use of an environment variable to control the extension creation during the PostgreSQL initialization process. We can edit the entrypoint script for the Docker image that checks the environment variable and enables TimescaleDB accordingly. Can you confirm whether we are on the same plate on implementing this, so that I can go ahead with the coding part :)

PR #12

ChakshuGautam commented 1 year ago

Hey, @jayanth-kumar-morem the PR looks good. I have removed the Build pipeline updates needed from the checklist. I will add it as a separate ticket.

jayanth-kumar-morem commented 1 year ago

Okay @ChakshuGautam , is there anything else we need to work on this issue before merging the code. ?