search

Samagra-Development / WarpSQL

WarpSQL
https://samagra-development.github.io/WarpSQL/
Apache License 2.0
16 stars 28 forks source link

[CI] Fix failing workflow for bitnami #41

Closed PiyushRaj927 closed 1 year ago

PiyushRaj927 commented 1 year ago

Version mismatch causing workflow failure: https://github.com/Samagra-Development/WarpSQL/actions/runs/5133893971/jobs/9237125480#step:3:5382.

  1. updated PostGIS version for Bitnami image
jayanth-kumar-morem commented 1 year ago

Hi @PiyushRaj927 , The CI is passing in this commit 5faa6fcc26e7d6d2325c096f47ffeb145a2e2b65 . You are updating the PostGIS version from 3.2 to 3.3 which is well and good. Just want to check in with what pgdg110 corresponds to, because if its corresponds to pg11, this version 3.3.3+dfsg-1~exp1.pgdg110+1 is not accepted as of now because we are specifically running the smoketests for pg15.

PiyushRaj927 commented 1 year ago

@jayanth-kumar-morem, there seems to be an issue with the PostGIS apt repo. Issue has been filed here: https://github.com/postgis/docker-postgis/issues/346. It think "pgdp110" refers to Debian 11 rather than postgres11. I took the version from https://github.com/postgis/docker-postgis/blob/40217724be568a7e08e8a07acd2b5406cedb7881/15-3.3/Dockerfile#L12 you can see that the folder is for postgres 15 also 

#18 20.14 Reading package lists...
#18 21.03 Package: postgresql-15-postgis-3
#18 21.03 Versions: 
#18 21.03 3.3.3+dfsg-1~exp1.pgdg110+1 (/var/lib/apt/lists/apt.postgresql.org_pub_repos_apt_dists_bullseye-pgdg_main_binary-amd64_Packages.lz4)
#18 21.03  Description Language: 
#18 21.03                  File: /var/lib/apt/lists/apt.postgresql.org_pub_repos_apt_dists_bullseye-pgdg_main_binary-amd64_Packages.lz4
#18 21.03                   MD5: 4a9cae2479a434ba3a1733f5c284a603

3.3.3+dfsg-1~exp1.pgdg110+1 is the only version available currently in the repo

jayanth-kumar-morem commented 1 year ago

If we can't rely on PostGIS apt repo, I think its best we can get Postgis official source tarball releases here http://postgis.net/source/ and install it manually.

PiyushRaj927 commented 1 year ago

Agreed. Can we merge this as a temporary fix until we implement the suggested approach mentioned earlier

jayanth-kumar-morem commented 1 year ago

@ChakshuGautam , we are installing PostGIS from apt repo now, which can be considered as a temporary fix for GHA. Later if we encounter a similar issue with PostGIS, we need to definitely consider installing PostGIS from sources / official PostGIS repo.

+1 Merge it as a temporary fix