search

Samagra-Development / WarpSQL

WarpSQL
https://samagra-development.github.io/WarpSQL/
Apache License 2.0
16 stars 28 forks source link

add hyperloglog #44

Closed PiyushRaj927 closed 1 year ago

PiyushRaj927 commented 1 year ago

Fixes #9

  1. Installed the necessary build dependency.
  2. Downloaded hyperloglog v2.17 from https://github.com/citusdata/postgresql-hll and built it.
  3. Installed hyperloglog.
  4. Cleaned up the build dependencies.
  5. Added POSTGRES_HLL_VERSION as an argument in the Makefile.
  6. Added hll to share_preload_libraries.
  7. Updated the smoke test for hyperloglog.

    Testing

I have test the images locally and have found no issues

PiyushRaj927 commented 1 year ago

@jayanth-kumar-morem, would you mind reviewing this when you have a chance?

jayanth-kumar-morem commented 1 year ago

Hey @PiyushRaj927 , The code looks clean. GHA are failing due to some postgis version ig. Can you pin your forked repo passing GHA for this PR, so that we can merge it.

PiyushRaj927 commented 1 year ago

Hi @jayanth-kumar-morem, I have merged the version patches, and all the GitHub Actions are passing successfully.