search

Samagra-Development / WarpSQL

WarpSQL
https://samagra-development.github.io/WarpSQL/
Apache License 2.0
15 stars 30 forks source link

add packer template #77

Closed PiyushRaj927 closed 1 year ago

PiyushRaj927 commented 1 year ago

Fixes #51 This PR adds/improves

  1. a Packer template that enables building images with installed extensions using a parametric approach. By default, all supported extensions are installed. To install specific extensions, you can provide the extensions variable when running the command:

    packer build -var extensions='pg_repack,hll' -only warpsql.docker.alpine war

  2. GitHub workflow to test each extension individually as well as all of them within an image. By default, the test script test/smoke_test/smoke_test.sh will execute all the scripts in the extensions_test directory. You can specify which tests to run by providing a comma-separated list of extensions as an argument to the script. Here's an example of how to run specific tests:

    ./test/smoke_test/smoke_test.sh "hll,pg_reapck"

  3. updated README.md file with instructions on how to use the Packer template.

PiyushRaj927 commented 1 year ago

cc: @singhalkarun

singhalkarun commented 1 year ago

Hi @PiyushRaj927 trying to understand why have you created 2 different packer temlates, generally intent of using packer is to be able to build for multiple platforms using a single template file? Also, would be great if you can add comments in the code that helps end user understand the flow and makes it easy for someone to contribute ahead in future.

PiyushRaj927 commented 1 year ago

Hi @singhalkarun, I created two separate templates during the POC phase to test different configurations. However, I agree it's best to combine them into a single template now. I'll also add a README file with clear instructions and comments to help future contributors. Thanks for your feedback!

PiyushRaj927 commented 1 year ago

Hey @singhalkarun, could you please review the changes?

singhalkarun commented 1 year ago

@PiyushRaj927 Can you please check why the actions are running infinitely? Also can you brief in the description of PR itself what the action does? Generally, going forward, please brief all the changes done in PR Description.

Running Infinitely Running
PiyushRaj927 commented 1 year ago

@singhalkarun I have made updates to the PR description and included a workflow to test each extension individually. Please review these changes.

PiyushRaj927 commented 1 year ago

Regarding the issue with the infinitely running action, it appears that there was an outage on GitHub (you can check the details here: GitHub Status). This outage might have caused a bug to arise while running the specific action. I'm not entirely sure how to fix it.

singhalkarun commented 1 year ago

@PiyushRaj927 Can you raise a new PR with squashed commits, I merged by mistake (have force removed changes from main branch), I will merge new PR