search

Samagra-Development / WarpSQL

WarpSQL
https://samagra-development.github.io/WarpSQL/
Apache License 2.0
16 stars 28 forks source link

Implement Code Linters #86

Open PiyushRaj927 opened 1 year ago

PiyushRaj927 commented 1 year ago

In order to maintain consistent code quality and identify problems early on, we should incorporate a linters into our workflow. This will assist in streamlining the code review process as well.

PiyushRaj927 commented 1 year ago

Considering https://github.com/super-linter/super-linter as it is the easiest to set up, but lacks a local version for testing changes before committing. Should we opt for implementing individual linters for our specific needs instead ? cc: @jayanth-kumar-morem, @singhalkarun

ChakshuGautam commented 1 year ago

Hey @PiyushRaj927 couple of things

  1. Can you list down the type of errors that you are seeing frequently? Files and line numbers would help categorize these issues.
  2. Can you share your dev environment? Are you looking for something like a cli-based linter that runs using husky pre-commit hooks?
PiyushRaj927 commented 1 year ago

Hey @ChakshuGautam, I haven't encountered any errors so far. Could you please provide more information about the errors you mentioned? I'm not entirely sure what you're referring to.

Regarding the development environment, I appreciate you mentioning pre-commit hooks. I wasn't familiar with them before, but they seem to be exactly what I was looking for. Additionally, incorporating a linter workflow along with the pre-hooks to validate pull requests should fulfill the requirements I had in mind.

Regarding my development environment, I'm using Windows 10 with WSL2 Ubuntu and Docker Desktop.

Gmin2 commented 7 months ago

Hey @PiyushRaj927 can you please twell why #103 was closed, is the super-linter still needed