Closed PiyushRaj927 closed 1 year ago
Hey @singhalkarun can you review the PR when you get the chance. The test is failing because forked repos can't have write access in PRs. You can see it working in my forked repo at https://github.com/PiyushRaj927/WarpSQL/pull/3
Hey @singhalkarun can you review the PR when you get the chance. The test is failing because forked repos can't have write access in PRs. You can see it working in my forked repo at PiyushRaj927#3
While I was researching more about the access available to the workflows, I discovered that the pull_request
event for forked pull requests doesn't have write access by default, as it poses a security risk. I found a better approach, which involves a two-step process, explained in detail in https://stackoverflow.com/questions/69499645/how-to-securely-allow-github-actions-to-check-pr-and-post-results-in-comment. I will implement this method and incorporate the suggested changes mentioned in the initial review.
sts doesn't have writ
Hey @PiyushRaj927 can we create a different workflow for image analysis if possible to keep things separate?
I have tested the workflow and made the necessary changes. You can see it working at https://github.com/anmolchhabra21/WarpSQL/pull/25.
Hey @singhalkarun, I have added comments and formatted the code. If any part is unclear, please let me know, and I'll provide clarifications. I will also include a document explaining the workflow soon
Fixes #42 This PR add workflows that analyze the size differences in the Docker image. The key features of this PR are:
The process involves two workflows: image-analysis.yml and image-analysis-comment.yml.
The image-analysis.yml workflow, which lacks write permissions on issues, is responsible for importing the image, conducting the analysis, exporting the details as comments in the pull request, and updating the comparison metrics when a push occurs on the main branch.
On the other hand, the image-analysis-comment.yml workflow writes the comments to their respective issues and hide bot messages from old runs.