Samagra-Development / yaus

Yet Another URL Shortner
https://github.com/Samagra-Development/yaus/wiki
11 stars 28 forks source link

Added YAUS frontend developed in C4GT"22 #56

Closed Nazi-pikachu closed 1 year ago

Nazi-pikachu commented 1 year ago

Description PR to add the code developed as part of C4GT" 22

Changes Added the code developed as part of C4GT" 22

To DO

How to test

  1. Setup the codebase locally
  2. yarn test api

Ref : #52

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 0b25c5cb809075d3d896d4c75bb26db01d3e36d7 | yaus_c4gt_frontend/src/pages/SignIn.js | [View secret](https://github.com/Samagra-Development/yaus/commit/0b25c5cb809075d3d896d4c75bb26db01d3e36d7#diff-fe55bf7f47b0ebc9c0ece209b2699463L144) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 0b25c5cb809075d3d896d4c75bb26db01d3e36d7 | yaus_c4gt_frontend/src/pages/SignUp.js | [View secret](https://github.com/Samagra-Development/yaus/commit/0b25c5cb809075d3d896d4c75bb26db01d3e36d7#diff-2f0b7d58c3de7b59611c32482e329522L140) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 423e24db035fa1f249c2d4843878597d88b15ada | yaus_c4gt_frontend/src/pages/SignIn.js | [View secret](https://github.com/Samagra-Development/yaus/commit/423e24db035fa1f249c2d4843878597d88b15ada#diff-fe55bf7f47b0ebc9c0ece209b2699463R144) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | 423e24db035fa1f249c2d4843878597d88b15ada | yaus_c4gt_frontend/src/pages/SignUp.js | [View secret](https://github.com/Samagra-Development/yaus/commit/423e24db035fa1f249c2d4843878597d88b15ada#diff-2f0b7d58c3de7b59611c32482e329522R140) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic High Entropy Secret | d5ccf568781bd0076614e5415ea805cf9f96e108 | yaus_c4gt_sdk/sdk-generation/index.ts | [View secret](https://github.com/Samagra-Development/yaus/commit/d5ccf568781bd0076614e5415ea805cf9f96e108#diff-ef053593eed249f69b22588d51dd7f1eL6) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Nazi-pikachu commented 1 year ago

Hi @ChakshuGautam Can you provide some feedback on this draft PR.

MUCCHU commented 1 year ago

Hey @Shruti3004 is there anything that I can help with in this pull request. This PR was mentioned by @ChakshuGautam in Issue 52.

Nazi-pikachu commented 1 year ago

Marking this a draft since it would be a very big PR to review directly It would be better to discuss the problems in the frontend here that needs to fixed before merging it in the main codebase. Will be opening another PR to start the frontend migration work