Samagra-Development / yaus

Yet Another URL Shortner
https://github.com/Samagra-Development/yaus/wiki
11 stars 28 forks source link

Migration : Frontend #77

Closed Nazi-pikachu closed 1 year ago

Nazi-pikachu commented 1 year ago

Description

To migrate the frontend from previous seperate repo to the main repo

Changes Made

Generated a react-app using nx

Related Issues

Testing Instructions

  1. Follow the setup readme
  2. run nx serve frontend

Screenshots (if applicable)

Current output image

Additional Notes

Its an intial PR in which the frontend code has been migrated to frontend app follow test instructions to know how to run the frontend.

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | caec5c47d0d660ada077d13d8e41fadac8cd582b | apps/frontend/src/app/apis/index.js | [View secret](https://github.com/Samagra-Development/yaus/commit/caec5c47d0d660ada077d13d8e41fadac8cd582b#diff-d01878b24a568331f8c17b4949a5b7b9L4) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | caec5c47d0d660ada077d13d8e41fadac8cd582b | apps/frontend/src/app/apis/index.js | [View secret](https://github.com/Samagra-Development/yaus/commit/caec5c47d0d660ada077d13d8e41fadac8cd582b#diff-d01878b24a568331f8c17b4949a5b7b9L16) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | 7cc3d8720ffc2fded8ab2292eab075269c6cee56 | apps/frontend/src/app/apis/index.js | [View secret](https://github.com/Samagra-Development/yaus/commit/7cc3d8720ffc2fded8ab2292eab075269c6cee56#diff-d01878b24a568331f8c17b4949a5b7b9R4) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Generic Password | 7cc3d8720ffc2fded8ab2292eab075269c6cee56 | apps/frontend/src/app/apis/index.js | [View secret](https://github.com/Samagra-Development/yaus/commit/7cc3d8720ffc2fded8ab2292eab075269c6cee56#diff-d01878b24a568331f8c17b4949a5b7b9R16) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Nazi-pikachu commented 1 year ago

Progress on this PR Till now